Prerender: update historgram utility functions.

chrome/browser/prerender/prerender_histograms.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prerender/prerender_histograms.h"
 
 #include <string>
 
 #include "base/format_macros.h"
 #include "base/logging.h"
@@ skipping 18 matching lines @@
   REDIRECT = 1 << 1,
   MAIN_RESOURCE = 1 << 2,
   NO_STATE_PREFETCH_RESPONSE_TYPE_COUNT = 1 << 3
 };
 
 int GetResourceType(bool is_main_resource, bool is_redirect, bool is_no_store) {
   return (is_no_store * NO_STORE) + (is_redirect * REDIRECT) +
          (is_main_resource * MAIN_RESOURCE);
 }
 
-// Similar to UMA_HISTOGRAM_ENUMERATION but allows a dynamic histogram name.
-// Records a sample such as 0 <= sample < bucket_count, in a histogram with
-// |bucket_count| buckets of width 1 each.
-void RecordHistogramEnum(const std::string& histogram_name,
-                         base::HistogramBase::Sample sample,
-                         base::HistogramBase::Sample bucket_count) {
-  DCHECK_LT(sample, bucket_count);
-  base::HistogramBase* histogram_pointer = base::LinearHistogram::FactoryGet(
-      histogram_name, 1, bucket_count, bucket_count + 1,
-      base::HistogramBase::kUmaTargetedHistogramFlag);
-  histogram_pointer->Add(sample);
-}
-
-// Similar to UMA_HISTOGRAM_CUSTOM_TIMES but allows a dynamic histogram name.
-void RecordHistogramTime(const std::string& histogram_name,
-                         base::TimeDelta time_min,
-                         base::TimeDelta time_max,
-                         base::TimeDelta sample,
-                         base::HistogramBase::Sample bucket_count) {
-  base::HistogramBase* histogram_pointer = base::Histogram::FactoryTimeGet(
-      histogram_name, time_min, time_max, bucket_count,
-      base::HistogramBase::kUmaTargetedHistogramFlag);
-  histogram_pointer->AddTime(sample);
-}
-
 // Time window for which we will record windowed PLTs from the last observed
 // link rel=prefetch tag. This is not intended to be the same as the prerender
 // ttl, it's just intended to be a window during which a prerender has likely
 // affected performance.
 const int kWindowDurationSeconds = 30;
 
 std::string ComposeHistogramName(const std::string& prefix_type,
                                  const std::string& name) {
   if (prefix_type.empty())
     return std::string("Prerender.") + name;
@@ skipping 359 matching lines @@
 void PrerenderHistograms::RecordPrefetchResponseReceived(
     Origin origin,
     bool is_main_resource,
     bool is_redirect,
     bool is_no_store) const {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   int sample = GetResourceType(is_main_resource, is_redirect, is_no_store);
   std::string histogram_name =
       GetHistogramName(origin, IsOriginWash(), "NoStatePrefetchResponseTypes");
-  RecordHistogramEnum(histogram_name, sample,
-                      NO_STATE_PREFETCH_RESPONSE_TYPE_COUNT);
+  base::UmaHistogramExactLinear(histogram_name, sample,
+                                NO_STATE_PREFETCH_RESPONSE_TYPE_COUNT);
 }
 
 void PrerenderHistograms::RecordPrefetchRedirectCount(
     Origin origin,
     bool is_main_resource,
     int redirect_count) const {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   const int kMaxRedirectCount = 10;
   std::string histogram_base_name = base::StringPrintf(
       "NoStatePrefetch%sResourceRedirects", is_main_resource ? "Main" : "Sub");
   std::string histogram_name =
       GetHistogramName(origin, IsOriginWash(), histogram_base_name);
-  RecordHistogramEnum(histogram_name, redirect_count, kMaxRedirectCount);
+  base::UmaHistogramExactLinear(histogram_name, redirect_count,
+                                kMaxRedirectCount);
 }
 
 void PrerenderHistograms::RecordPrefetchFirstContentfulPaintTime(
     Origin origin,
     bool is_no_store,
     bool was_hidden,
     base::TimeDelta time,
     base::TimeDelta prefetch_age) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   if (!prefetch_age.is_zero()) {
     DCHECK_NE(origin, ORIGIN_NONE);
-    RecordHistogramTime(GetHistogramName(origin, IsOriginWash(), "PrefetchAge"),
-                        base::TimeDelta::FromMilliseconds(10),
-                        base::TimeDelta::FromMinutes(30), prefetch_age, 50);
+    base::UmaHistogramCustomTimes(
+        GetHistogramName(origin, IsOriginWash(), "PrefetchAge"), prefetch_age,
+        base::TimeDelta::FromMilliseconds(10), base::TimeDelta::FromMinutes(30),
+        50);
   }
 
   std::string histogram_base_name;
   if (prefetch_age.is_zero()) {
     histogram_base_name = "PrefetchTTFCP.Reference";
   } else {
     histogram_base_name = prefetch_age < base::TimeDelta::FromMinutes(
                                              net::HttpCache::kPrefetchReuseMins)
                               ? "PrefetchTTFCP.Warm"
                               : "PrefetchTTFCP.Cold";
   }
 
   histogram_base_name += is_no_store ? ".NoStore" : ".Cacheable";
   histogram_base_name += FirstContentfulPaintHiddenName(was_hidden);
   std::string histogram_name =
       GetHistogramName(origin, IsOriginWash(), histogram_base_name);
 
-  RecordHistogramTime(histogram_name, base::TimeDelta::FromMilliseconds(10),
-                      base::TimeDelta::FromMinutes(2), time, 50);
+  base::UmaHistogramCustomTimes(histogram_name, time,
+                                base::TimeDelta::FromMilliseconds(10),
+                                base::TimeDelta::FromMinutes(2), 50);
 }
 
 bool PrerenderHistograms::IsOriginWash() const {
   if (!WithinWindow())
     return false;
   return origin_wash_;
 }
 
 }  // namespace prerender