Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/network_time/network_time_test_utils.h

Issue 2653443002: Update NetworkTimeQueries field trial config (Closed)
Patch Set: meacer suggestion: configure finch via command line Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_time/network_time_test_utils.h
diff --git a/components/network_time/network_time_test_utils.h b/components/network_time/network_time_test_utils.h
index 51b3c4f7c63657133754322d189d3644106ece4a..e9dd537606661c3f658b29a61361e1f57a8ab2d7 100644
--- a/components/network_time/network_time_test_utils.h
+++ b/components/network_time/network_time_test_utils.h
@@ -50,26 +50,18 @@ extern const double kGoodTimeResponseHandlerJsTime;
std::unique_ptr<net::test_server::HttpResponse> GoodTimeResponseHandler(
const net::test_server::HttpRequest& request);
-// Allows tests to configure the network time queries field trial.
+// Allows unit tests to configure the network time queries field trial.
class FieldTrialTest {
public:
+ FieldTrialTest();
virtual ~FieldTrialTest();
- // A FieldTrialList exists as a global singleton. Use
- // CreateForUnitTest() in unit tests to create a FieldTrialTest that
- // creates its own FieldTrialList; use CreateForBrowserTest() to use
- // the singleton FieldTrialList that is created during browser setup.
- static FieldTrialTest* CreateForUnitTest();
- static FieldTrialTest* CreateForBrowserTest();
-
void SetNetworkQueriesWithVariationsService(
bool enable,
float query_probability,
NetworkTimeTracker::FetchBehavior fetch_behavior);
private:
- FieldTrialTest();
- bool create_field_trial_list_ = true;
std::unique_ptr<base::FieldTrialList> field_trial_list_;
std::unique_ptr<base::test::ScopedFeatureList> scoped_feature_list_;

Powered by Google App Engine
This is Rietveld 408576698