Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/dom/templates/html/impl/impl_Window.darttemplate

Issue 26534005: Removing setImmediate and hiding WindowTimers interface (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/templates/html/dartium/html_dartium.darttemplate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Window.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Window.darttemplate b/tools/dom/templates/html/impl/impl_Window.darttemplate
index aaa1b97296d0dd76e9662ac907ce7ae04ce5292d..19999f4bea96d6434262100231177124aad6489e 100644
--- a/tools/dom/templates/html/impl/impl_Window.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Window.darttemplate
@@ -12,19 +12,6 @@ $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
$endif
/**
- * Executes a [callback] after the immediate execution stack has completed.
- *
- * This differs from using Timer.run(callback)
- * because Timer will run in about 4-15 milliseconds, depending on browser,
- * depending on load. [setImmediate], in contrast, makes browser-specific
- * changes in behavior to attempt to run immediately after the current
- * frame unwinds, causing the future to complete after all processing has
- * completed for the current event, but before any subsequent events.
- */
- void setImmediate(TimeoutHandler callback) {
- _addMicrotaskCallback(callback);
- }
- /**
* Lookup a port by its [name]. Return null if no port is
* registered under [name].
*/
@@ -221,44 +208,6 @@ $if DART2JS
@DomName('Window.console')
Console get console => Console._safeConsole;
-
- /// Checks if _setImmediate is supported.
- static bool get _supportsSetImmediate =>
- JS('bool', '!!(window.setImmediate)');
-
- // Set immediate implementation for IE
- void _setImmediate(void callback()) {
- JS('void', '#.setImmediate(#)', this, convertDartClosureToJS(callback, 0));
- }
-$else
- /// Checks if _setImmediate is supported.
- static bool get _supportsSetImmediate => false;
-
- /// Dartium stub for IE's setImmediate.
- void _setImmediate(void callback()) {
- throw new UnsupportedError('setImmediate is not supported');
- }
-
- /**
- * Called to draw an animation frame and then request the window to repaint
- * after [callback] has finished (creating the animation).
- *
- * Use this method only if you need to later call [cancelAnimationFrame]. If
- * not, the preferred Dart idiom is to set animation frames by calling
- * [animationFrame], which returns a Future.
- *
- * Returns a non-zero valued integer to represent the request id for this
- * request. This value only needs to be saved if you intend to call
- * [cancelAnimationFrame] so you can specify the particular animation to
- * cancel.
- *
- * Note: The supplied [callback] needs to call [requestAnimationFrame] again
- * for the animation to continue.
- */
- @DomName('Window.requestAnimationFrame')
- int requestAnimationFrame(RequestAnimationFrameCallback callback) {
- return _requestAnimationFrame(_wrapZone(callback));
- }
$endif
/**
« no previous file with comments | « tools/dom/templates/html/dartium/html_dartium.darttemplate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698