Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 26534002: Adding Cira & Mihai to OWNERS for internationalization (i18n) (Closed)

Created:
7 years, 2 months ago by mnita
Modified:
7 years, 2 months ago
Reviewers:
Nebojša Ćirić, danno
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

Adding Cira & Mihai to OWNERS for internationalization (i18n) Keeping the names together so that I can put one comment for both. Might also sort alphabetically, with the comment after each email. Not sure what option was best, I have seen it done both ways. R=cira@chromium.org, danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17168

Patch Set 1 #

Patch Set 2 : Adding Cira and Mihai as owners, restricted to internationalization areas. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A src/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A test/intl/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mnita
I have also seen the option to add per-file ownership, but I am not sure ...
7 years, 2 months ago (2013-10-09 17:12:59 UTC) #1
danno
I would prefer if you could set up ownership only for the files that you ...
7 years, 2 months ago (2013-10-10 09:19:57 UTC) #2
Nebojša Ćirić
On 2013/10/10 09:19:57, danno wrote: > I would prefer if you could set up ownership ...
7 years, 2 months ago (2013-10-10 16:35:06 UTC) #3
danno
lgtm, I'll land this for you
7 years, 2 months ago (2013-10-11 15:22:24 UTC) #4
danno
7 years, 2 months ago (2013-10-11 15:24:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17168 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698