third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js » ('j') | third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index 7dc4d44a27b2aa373a0413b21a8b67c3accd6b10..1f20c8d4be3170e078b15448b501e3acc90bb18c 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -149,10 +149,11 @@ Network.NetworkLogViewColumns = class {

function handleContextMenu(event) {

var node = this._waterfallColumn.getNodeFromPoint(event.offsetX, event.offsetY);

- if (!node)

+ var request = node.request();

+ if (!node || !request)

pfeldman 2017/01/26 00:16:29 !node check might come a bit too late

allada 2017/01/26 22:57:43 Done.

return;

var contextMenu = new UI.ContextMenu(event);

- this._networkLogView.handleContextMenuForRequest(contextMenu, node.request());

+ this._networkLogView.handleContextMenuForRequest(contextMenu, request);

contextMenu.show();

}