[Devtools] Added typing to network in prep for removing unrestricted

third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) IBM Corp. 2009  All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 198 matching lines @@
 
     var headerCount = createElementWithClass('span', 'header-count');
     headerCount.textContent = Common.UIString('\u00A0(%d)', params.length);
     paramsTreeElement.listItemElement.appendChild(headerCount);
 
     /**
      * @param {!Event} event
      * @this {Network.RequestHeadersView}
      */
     function toggleViewSource(event) {
-      paramsTreeElement._viewSource = !paramsTreeElement._viewSource;
+      paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol] =
+          !paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol];
       this._refreshParams(title, params, sourceText, paramsTreeElement);
       event.consume();
     }
 
-    paramsTreeElement.listItemElement.appendChild(
-        this._createViewSourceToggle(paramsTreeElement._viewSource, toggleViewSource.bind(this)));
+    paramsTreeElement.listItemElement.appendChild(this._createViewSourceToggle(
+        paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol], toggleViewSource.bind(this)));
 
-    if (paramsTreeElement._viewSource) {
+    if (paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol]) {
       this._populateTreeElementWithSourceText(paramsTreeElement, sourceText);
       return;
     }
 
     var toggleTitle =
         this._decodeRequestParameters ? Common.UIString('view URL encoded') : Common.UIString('view decoded');
     var toggleButton = this._createToggleButton(toggleTitle);
     toggleButton.addEventListener('click', this._toggleURLDecoding.bind(this), false);
     paramsTreeElement.listItemElement.appendChild(toggleButton);
 
@@ skipping 25 matching lines @@
 
     var listItem = this._requestPayloadCategory.listItemElement;
     listItem.removeChildren();
     listItem.createTextChild(this._requestPayloadCategory.title);
 
     /**
      * @param {!Event} event
      * @this {Network.RequestHeadersView}
      */
     function toggleViewSource(event) {
-      treeElement._viewSource = !treeElement._viewSource;
+      treeElement[Network.RequestHeadersView._viewSourceSymbol] =
+          !treeElement[Network.RequestHeadersView._viewSourceSymbol];
       this._refreshRequestJSONPayload(parsedObject, sourceText);
       event.consume();
     }
 
-    listItem.appendChild(this._createViewSourceToggle(treeElement._viewSource, toggleViewSource.bind(this)));
-    if (treeElement._viewSource) {
+    listItem.appendChild(this._createViewSourceToggle(
+        treeElement[Network.RequestHeadersView._viewSourceSymbol], toggleViewSource.bind(this)));
+    if (treeElement[Network.RequestHeadersView._viewSourceSymbol]) {
       this._populateTreeElementWithSourceText(this._requestPayloadCategory, sourceText);
     } else {
       var object = SDK.RemoteObject.fromLocalObject(parsedObject);
       var section = new Components.ObjectPropertiesSection(object, object.description);
       section.expand();
       section.editable = false;
       treeElement.appendChild(new UI.TreeElement(section.element));
     }
   }
 
@@ skipping 199 matching lines @@
   /**
    * @param {boolean} isHeadersTextShown
    * @return {!Element}
    */
   _createHeadersToggleButton(isHeadersTextShown) {
     var toggleTitle = isHeadersTextShown ? Common.UIString('view parsed') : Common.UIString('view source');
     return this._createToggleButton(toggleTitle);
   }
 };
 
+Network.RequestHeadersView._viewSourceSymbol = Symbol('ViewSource');

[pfeldman, 2017/01/25 23:54:18]

That does not look automated!

[allada, 2017/01/26 00:06:34]

This patch is not the automated stuff. This is the stuff my script cannot do.

+
 /**
  * @unrestricted
  */
 Network.RequestHeadersView.Category = class extends UI.TreeElement {
   /**
    * @param {!UI.TreeOutline} root
    * @param {string} name
    * @param {string=} title
    */
   constructor(root, name, title) {
@@ skipping 23 matching lines @@
     this._expandedSetting.set(true);
   }
 
   /**
    * @override
    */
   oncollapse() {
     this._expandedSetting.set(false);
   }
 };