[Devtools] Added typing to network in prep for removing unrestricted

third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Network.NetworkWaterfallColumn = class extends UI.VBox {
   /**
    * @param {number} rowHeight
    * @param {!Network.NetworkTimeCalculator} calculator
@@ skipping 12 matching lines @@
     this._leftPadding = 5;
     /** @const */
     this._fontSize = 10;
 
     this._rightPadding = 0;
 
     this._rowHeight = rowHeight;
     this._headerHeight = 0;
     this._calculator = calculator;
 
+    this._offsetWidth = 0;
+    this._offsetHeight = 0;
+    this._startTime = this._calculator.minimumBoundary();

[pfeldman, 2017/01/26 00:16:29]

You are changing the logic here, now calculator is accessed before the update
(not sure it is bad, but it is different).

[allada, 2017/01/26 22:57:43]

In this case it should not matter since the only time it is accessed without
being reset is in a popover, but it must have data by the time popover anchor
knows about ranges.

+    this._endTime = this._calculator.maximumBoundary();
+
     this._popoverHelper = new UI.PopoverHelper(this.element);
     this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
     this._popoverHelper.setTimeout(300, 300);
 
     /** @type {!Array<!Network.NetworkNode>} */
     this._nodes = [];
 
     /** @type {?Network.NetworkNode} */
     this._hoveredNode = null;
 
@@ skipping 164 matching lines @@
     if (scrollTop !== undefined && this._scrollTop !== scrollTop) {
       this._popoverHelper.hidePopover();
       this._scrollTop = scrollTop;
     }
     if (nodes) {
       this._nodes = nodes;
       this._calculateCanvasSize();
     }
     if (eventDividers !== undefined)
       this._eventDividers = eventDividers;
-    this.element.window().cancelAnimationFrame(this._updateRequestID);
-    this._updateRequestID = null;
+    if (this._updateRequestID) {
+      this.element.window().cancelAnimationFrame(this._updateRequestID);
+      delete this._updateRequestID;
+    }
 
     this._startTime = this._calculator.minimumBoundary();
     this._endTime = this._calculator.maximumBoundary();
     this._resetCanvas();
     this._draw();
   }
 
   _resetCanvas() {
     var ratio = window.devicePixelRatio;
     this._canvas.width = this._offsetWidth * ratio;
@@ skipping 411 matching lines @@
   font: 'hsl(8, 100%, 80%)',
   media: 'hsl(90, 50%, 80%)',
   image: 'hsl(90, 50%, 80%)',
   script: 'hsl(31, 100%, 80%)',
   stylesheet: 'hsl(272, 64%, 80%)',
   texttrack: 'hsl(8, 100%, 80%)',
   websocket: 'hsl(0, 0%, 95%)',
   xhr: 'hsl(53, 100%, 80%)',
   other: 'hsl(0, 0%, 95%)'
 };