Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 /** | 4 /** |
| 5 * @unrestricted | 5 * @unrestricted |
| 6 */ | 6 */ |
| 7 Network.NetworkLogViewColumns = class { | 7 Network.NetworkLogViewColumns = class { |
| 8 /** | 8 /** |
| 9 * @param {!Network.NetworkLogView} networkLogView | 9 * @param {!Network.NetworkLogView} networkLogView |
| 10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator | 10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator |
| (...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 142 this._splitWidget.setSidebarWidget(this._waterfallColumn); | 142 this._splitWidget.setSidebarWidget(this._waterfallColumn); |
| 143 | 143 |
| 144 this.switchViewMode(false); | 144 this.switchViewMode(false); |
| 145 | 145 |
| 146 /** | 146 /** |
| 147 * @param {!Event} event | 147 * @param {!Event} event |
| 148 * @this {Network.NetworkLogViewColumns} | 148 * @this {Network.NetworkLogViewColumns} |
| 149 */ | 149 */ |
| 150 function handleContextMenu(event) { | 150 function handleContextMenu(event) { |
| 151 var node = this._waterfallColumn.getNodeFromPoint(event.offsetX, event.off setY); | 151 var node = this._waterfallColumn.getNodeFromPoint(event.offsetX, event.off setY); |
| 152 if (!node) | 152 var request = node.request(); |
| 153 if (!node || !request) | |
|
pfeldman
2017/01/26 00:16:29
!node check might come a bit too late
allada
2017/01/26 22:57:43
Done.
| |
| 153 return; | 154 return; |
| 154 var contextMenu = new UI.ContextMenu(event); | 155 var contextMenu = new UI.ContextMenu(event); |
| 155 this._networkLogView.handleContextMenuForRequest(contextMenu, node.request ()); | 156 this._networkLogView.handleContextMenuForRequest(contextMenu, request); |
| 156 contextMenu.show(); | 157 contextMenu.show(); |
| 157 } | 158 } |
| 158 } | 159 } |
| 159 | 160 |
| 160 /** | 161 /** |
| 161 * @param {boolean} shouldConsume | 162 * @param {boolean} shouldConsume |
| 162 * @param {!Event} event | 163 * @param {!Event} event |
| 163 */ | 164 */ |
| 164 _onMouseWheel(shouldConsume, event) { | 165 _onMouseWheel(shouldConsume, event) { |
| 165 if (shouldConsume) | 166 if (shouldConsume) |
| (...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 803 /** | 804 /** |
| 804 * @enum {string} | 805 * @enum {string} |
| 805 */ | 806 */ |
| 806 Network.NetworkLogViewColumns.WaterfallSortIds = { | 807 Network.NetworkLogViewColumns.WaterfallSortIds = { |
| 807 StartTime: 'startTime', | 808 StartTime: 'startTime', |
| 808 ResponseTime: 'responseReceivedTime', | 809 ResponseTime: 'responseReceivedTime', |
| 809 EndTime: 'endTime', | 810 EndTime: 'endTime', |
| 810 Duration: 'duration', | 811 Duration: 'duration', |
| 811 Latency: 'latency' | 812 Latency: 'latency' |
| 812 }; | 813 }; |
| OLD | NEW |