Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2653343002: Improve performance of visiting large invalid compilation units (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve performance of visiting large invalid compilation units R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f6f2ecfe69d82b4e3a503a68c16ff950e6982235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Users aren't likely to run into this case, but still... analyzer is re-sorting all of ...
3 years, 11 months ago (2017-01-25 22:51:47 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-25 22:54:36 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-25 22:55:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6f2ecfe69d82b4e3a503a68c16ff950e6982235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698