chrome/browser/conflicts/module_info_util_win.h - Issue 2653333002: [win] Create utilities for helping to populate ModuleDatabase.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/conflicts/module_info_util_win.h

Issue 2653333002: [win] Create utilities for helping to populate ModuleDatabase. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CONFLICTS_MODULE_INFO_UTIL_WIN_H_

	6 #define CHROME_BROWSER_CONFLICTS_MODULE_INFO_UTIL_WIN_H_

	7

	8 #include "chrome/browser/conflicts/module_database_win.h"

	9

	10 // Extracts information about the certificate of the given \|file\|, populating

	11 // \|cert_info\|. It is expected that \|cert_info\| be freshly constructed.

	12 void GetCertificateInfo(const base::FilePath& file,
	Patrick Monette 2017/01/26 20:49:07 Is it too much trouble to remove the duplicate cod Is it too much trouble to remove the duplicate code in enumerate_modules_model.cc and directly call this? chrisha 2017/02/06 18:38:46 Done! Show quoted text On 2017/01/26 20:49:07, Patrick Monette wrote: > Is it too much trouble to remove the duplicate code in > enumerate_modules_model.cc and directly call this? Done!
	13 ModuleDatabase::CertificateInfo* cert_info);

	14

	15 #endif // CHROME_BROWSER_CONFLICTS_MODULE_INFO_UTIL_WIN_H_

OLD	NEW