Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: components/password_manager/content/browser/PRESUBMIT.py

Issue 2653273003: Add presubmit scripts to check histograms.xml if bad_message.h changes. (Closed)
Patch Set: address isherman comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/PRESUBMIT.py
diff --git a/components/password_manager/content/browser/PRESUBMIT.py b/components/password_manager/content/browser/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..4e16eb2436abf2810e5fdcff4f9b16327bf66526
--- /dev/null
+++ b/components/password_manager/content/browser/PRESUBMIT.py
@@ -0,0 +1,27 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+"""Chromium presubmit script to check that BadMessage enums in histograms.xml
+match the corresponding bad_message.h file.
+"""
+
+def _RunHistogramChecks(input_api, output_api, histogram_name):
+ try:
+ # Setup sys.path so that we can call histrogram code
+ import sys
+ original_sys_path = sys.path
+ sys.path = sys.path + [input_api.os_path.join(
+ input_api.change.RepositoryRoot(),
+ 'tools', 'metrics', 'histograms')]
+
+ import presubmit_bad_message_reasons
+ return presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
+ output_api, histogram_name)
+ except:
+ return [output_api.PresubmitError('Could not verify histogram!')]
+ finally:
+ sys.path = original_sys_path
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _RunHistogramChecks(input_api, output_api,
+ "BadMessageReasonPasswordManager")

Powered by Google App Engine
This is Rietveld 408576698