Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Side by Side Diff: components/nacl/browser/PRESUBMIT.py

Issue 2653273003: Add presubmit scripts to check histograms.xml if bad_message.h changes. (Closed)
Patch Set: address isherman comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4 """Chromium presubmit script to check that BadMessage enums in histograms.xml
brettw 2017/02/01 00:28:22 Can you put a blank line between the copyright and
dougt 2017/02/01 02:49:06 Done.
5 match the corresponding bad_message.h file.
6 """
7
8 def _RunHistogramChecks(input_api, output_api, histogram_name):
9 try:
10 # Setup sys.path so that we can call histrogram code
11 import sys
12 original_sys_path = sys.path
13 sys.path = sys.path + [input_api.os_path.join(
14 input_api.change.RepositoryRoot(),
15 'tools', 'metrics', 'histograms')]
16
17 import presubmit_bad_message_reasons
18 return presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
19 output_api, histogram_name)
20 except:
21 return [output_api.PresubmitError('Could not verify histogram!')]
22 finally:
23 sys.path = original_sys_path
24
25 def CheckChangeOnUpload(input_api, output_api):
26 return _RunHistogramChecks(input_api, output_api, "BadMessageReasonNaCl")
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698