Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 2653223003: Revert of Shape Detection: Implement FaceDetection on Mac as out-of-process service (Closed)

Created:
3 years, 11 months ago by mastiz
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mac-reviews_chromium.org, qsr+mojo_chromium.org, Reilly Grant (use Gerrit), viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Shape Detection: Implement FaceDetection on Mac as out-of-process service (patchset #14 id:1670001 of https://codereview.chromium.org/2528743002/ ) Reason for revert: Culprit suspect for blink_heap_unittests failing on chromium.webkit/WebKit Android (Nexus4), e.g. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/59943/steps/blink_heap_unittests/logs/stdio Original issue's description: > Shape Detection: Implement FaceDetection on Mac as out-of-process service > > This CL implements FaceDetection in //services/shape_detection. The Browser > forwards requests from the Renderer process to a Utility process, which detects > faces using Mac native CoreImage library and returns detection result. > > > > DESIGN_DOC=http://tinyurl.com/shape-detection-in-chromium > BUG=659139 > TEST=content/browser/shapedetection/shapedetection_browsertest.cc > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2528743002 > Cr-Commit-Position: refs/heads/master@{#445942} > Committed: https://chromium.googlesource.com/chromium/src/+/6dd8f460d0fe4567a7cb14ee5a3acc183d5325fb TBR=jochen@chromium.org,avi@chromium.org,haraken@chromium.org,mcasas@chromium.org,rockot@chromium.org,rsesek@chromium.org,tsepez@chromium.org,yzshen@chromium.org,xianglu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -466 lines) Patch
M content/browser/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 3 chunks +0 lines, -5 lines 0 comments Download
D content/browser/shapedetection/face_detection_service_dispatcher.h View 1 chunk +0 lines, -33 lines 0 comments Download
M content/browser/shapedetection/shapedetection_browsertest.cc View 4 chunks +6 lines, -13 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -5 lines 0 comments Download
M content/utility/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/utility/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/utility/utility_service_factory.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M services/service_manager/public/cpp/connector.h View 1 chunk +0 lines, -6 lines 0 comments Download
D services/shape_detection/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D services/shape_detection/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D services/shape_detection/README.md View 1 chunk +0 lines, -2 lines 0 comments Download
D services/shape_detection/face_detection_impl_mac.h View 1 chunk +0 lines, -35 lines 0 comments Download
D services/shape_detection/face_detection_impl_mac.mm View 1 chunk +0 lines, -127 lines 0 comments Download
D services/shape_detection/face_detection_provider_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D services/shape_detection/face_detection_provider_impl.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D services/shape_detection/manifest.json View 1 chunk +0 lines, -15 lines 0 comments Download
M services/shape_detection/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D services/shape_detection/public/interfaces/constants.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
D services/shape_detection/shape_detection_service.h View 1 chunk +0 lines, -38 lines 0 comments Download
D services/shape_detection/shape_detection_service.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mastiz
Created Revert of Shape Detection: Implement FaceDetection on Mac as out-of-process service
3 years, 11 months ago (2017-01-25 15:09:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653223003/1
3 years, 11 months ago (2017-01-25 15:09:46 UTC) #3
Ken Rockot(use gerrit already)
Sorry, we're aware of this bug. It's not this CL that is at fault and ...
3 years, 11 months ago (2017-01-25 15:46:42 UTC) #5
mastiz
3 years, 11 months ago (2017-01-25 15:52:51 UTC) #6
On 2017/01/25 15:46:42, Ken Rockot wrote:
> Sorry, we're aware of this bug. It's not this CL that is at fault and a fix is
> in flight.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698