Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: pkg/front_end/lib/src/fasta/testing/kernel_chain.dart

Issue 2653223002: Update status files and expectations of rasta tests. (Closed)
Patch Set: Rebased on 683fe6ab7c1925cfb63f7b36a7ff6088e4ff937e Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/test/fasta/compile.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
diff --git a/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart b/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
index ded157d032482d0b88bbdd526159be64b489d8cb..f5ecfdd538cac83983f61f80c07a62053c8cc2dc 100644
--- a/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
+++ b/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
@@ -247,6 +247,12 @@ class MatchExpectation extends Step<Program, Program, dynamic> {
StringBuffer buffer = new StringBuffer();
new Printer(buffer).writeLibraryFile(library);
+ bool updateExpectations = this.updateExpectations;
+ if (uri.path.contains("/test/rasta/")) {
+ // TODO(ahe): Remove this. Short term, we don't want to automatically
+ // update rasta expectations, as we have too many failures.
+ updateExpectations = false;
+ }
File expectedFile = new File("${uri.toFilePath()}$suffix");
if (await expectedFile.exists()) {
String expected = await expectedFile.readAsString();
« no previous file with comments | « no previous file | pkg/front_end/test/fasta/compile.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698