Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2653223002: Update status files and expectations of rasta tests. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on 683fe6ab7c1925cfb63f7b36a7ff6088e4ff937e #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -9 lines) Patch
M pkg/front_end/lib/src/fasta/testing/kernel_chain.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 1 chunk +66 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 1 chunk +83 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/enum.dart.dartk.expect View 1 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000043.dart.dartk.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/malformed_function.dart.dartk.expect View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
ahe
3 years, 10 months ago (2017-01-27 23:18:52 UTC) #5
karlklose
LGTM
3 years, 10 months ago (2017-01-31 11:31:21 UTC) #6
ahe
3 years, 10 months ago (2017-02-01 12:35:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:80001) manually as
ef8ec26cf36d1f07b4fdf5d605003210826ae1c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698