Issue 2653203005: Add NullByteStore, that does not store any data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2653203005: Add NullByteStore, that does not store any data. (Closed)

Created:
3 years, 11 months ago by scheglov

Modified:
3 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add NullByteStore, that does not store any data. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/12191284aa6c6d59429873b5f34aca23752ffb5d

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/byte_store.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/analysis/byte_store_test.dart	View		2 chunks	+15 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2653203005/diff/1/pkg/analyzer/test/src/dart/analysis/byte_store_test.dart File pkg/analyzer/test/src/dart/analysis/byte_store_test.dart (right): https://codereview.chromium.org/2653203005/diff/1/pkg/analyzer/test/src/dart/analysis/byte_store_test.dart#newcode17 pkg/analyzer/test/src/dart/analysis/byte_store_test.dart:17: List<int> _b(int length) { This is only used ...

3 years, 11 months ago (2017-01-26 14:51:18 UTC) #2

scheglov

3 years, 11 months ago (2017-01-26 15:21:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
12191284aa6c6d59429873b5f34aca23752ffb5d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages