Issue 26532002: Get rid of of custom code for Clipboard.setDragImage()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26532002: Get rid of of custom code for Clipboard.setDragImage() (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of of custom code for Clipboard.setDragImage() Introduce a setDragImage() method in Clipboard whose prototype matches the JavaScript one. Have this method call setDragImageResource() or setDragImageElement() depending on the input type. The first parameter type in Web IDL is now an Element, to match the specification: http://www.w3.org/html/wg/drafts/html/master/editing.html#datatransfer There is no web-exposed behavior change. TEST=ManualTests/drag-with-div-or-image-as-data-image.html R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159196

Patch Set 1 #

Patch Set 2 : Rebase on master #

Patch Set 3 : Rebase on master #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -80 lines)			Patch
M	Source/bindings/bindings.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/bindings/v8/custom/V8ClipboardCustom.cpp	View	1	1 chunk	+0 lines, -75 lines	0 comments	Download
M	Source/core/dom/Clipboard.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/core/dom/Clipboard.cpp	View	1	2 chunks	+18 lines, -1 line	0 comments	Download
M	Source/core/dom/Clipboard.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26532002/7001

7 years, 2 months ago (2013-10-09 00:38:53 UTC) #3

Message was sent while issue was closed.

Change committed as 159196

Expand Messages | Collapse Messages