Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: net/url_request/url_fetcher_core.cc

Issue 2653183006: Make URLFetcherCore::ReleaseRequest() release |buffer_|. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_fetcher_core.cc
diff --git a/net/url_request/url_fetcher_core.cc b/net/url_request/url_fetcher_core.cc
index 2a7a4d2899830a41287eab8107b5f2f462ece75d..f23ef3bd86f2bc81732dd6637edf2a753b41ae9a 100644
--- a/net/url_request/url_fetcher_core.cc
+++ b/net/url_request/url_fetcher_core.cc
@@ -816,6 +816,7 @@ void URLFetcherCore::ReleaseRequest() {
request_context_getter_->RemoveObserver(this);
upload_progress_checker_timer_.reset();
request_.reset();
+ buffer_ = nullptr;
mmenke 2017/01/25 16:12:30 BUG: In some cases, URLFetcherCores retry request
xunjieli 2017/01/25 16:28:15 Done. Thanks! I forgot about the retry on 5xx and
g_registry.Get().RemoveURLFetcherCore(this);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698