third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h - Issue 2653153003: Emit trace(Visitor*) rather than a templated trace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h

Issue 2653153003: Emit trace(Visitor*) rather than a templated trace(). (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h b/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h

index 7bf1606b291830f847143527b581a3ae93f3e223..35228043853a816f61e822252d2cf9c88efd3376 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h

@@ -34,8 +34,7 @@ class V8TestConstants {

}

CORE_EXPORT static TestConstants* toImplWithTypeCheck(v8::Isolate*, v8::Local<v8::Value>);

CORE_EXPORT static const WrapperTypeInfo wrapperTypeInfo;

- template<typename VisitorDispatcher>

- static void trace(VisitorDispatcher visitor, ScriptWrappable* scriptWrappable) {

+ static void trace(Visitor* visitor, ScriptWrappable* scriptWrappable) {

visitor->trace(scriptWrappable->toImpl<TestConstants>());

}

static void traceWrappers(WrapperVisitor* visitor, ScriptWrappable* scriptWrappable) {