third_party/WebKit/Source/bindings/templates/interface.h.tmpl - Issue 2653153003: Emit trace(Visitor*) rather than a templated trace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

Issue 2653153003: Emit trace(Visitor*) rather than a templated trace(). (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

index a828a5de7042f9f22f7fbf1783b537a1941c8dcb..69e93d8ca8fc75cb72f855c8e824e79d4ee707d2 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

@@ -47,8 +47,7 @@ class {{v8_class}} {

{% else %}

{{exported}}static const WrapperTypeInfo wrapperTypeInfo;

{% endif %}

- template<typename VisitorDispatcher>

- static void trace(VisitorDispatcher visitor, ScriptWrappable* scriptWrappable) {

+ static void trace(Visitor* visitor, ScriptWrappable* scriptWrappable) {

visitor->trace(scriptWrappable->toImpl<{{cpp_class}}>());

}

static void traceWrappers(WrapperVisitor* visitor, ScriptWrappable* scriptWrappable) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h » ('j') | no next file with comments »