Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 26531003: Minimal push mode scanner around the experimental rules. (Closed)

Created:
7 years, 2 months ago by marja
Modified:
7 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Minimal push mode scanner around the experimental rules. - Had to extend the rules a bit (it wouldn't compile). - The rules are still mostly toy rules (see the number recognition for example). BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17169

Patch Set 1 #

Patch Set 2 : generate condition names #

Patch Set 3 : the first almost reasonable version #

Patch Set 4 : moar fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -128 lines) Patch
M src/lexer/lexer.re View 1 2 3 1 chunk +460 lines, -128 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
lgtm
7 years, 2 months ago (2013-10-11 15:37:55 UTC) #1
marja
7 years, 2 months ago (2013-10-11 15:38:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #4 manually as r17169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698