Issue 26531002: Add crop rect support for SkDisplacementMapEffect (raster and GPU paths).

Issue 26531002: Add crop rect support for SkDisplacementMapEffect (raster and GPU paths). (Closed)

Created:
7 years, 2 months ago by Stephen White

Modified:
7 years, 2 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add crop rect support for SkDisplacementMapEffect (raster and GPU paths). Covered by new test cases added to displacement GM (will require rebaseline). R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11782

Patch Set 1 #

Patch Set 2 : Revert changes for color/displacement offset in GPU path. Add suppressions to ignored-tests.txt. #

Patch Set 3 : Embiggen the GM result size to accommodate the new test cases #

Total comments: 1

Patch Set 4 : Update to new CropRect API. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -33 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gm/displacement.cpp	View	1 2 3	2 chunks	+57 lines, -4 lines	0 comments	Download
M	include/effects/SkDisplacementMapEffect.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/effects/SkDisplacementMapEffect.cpp	View	1 2 3	7 chunks	+40 lines, -28 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Brian, Mike: PTAL. Thanks! (Note that SkOffsetImageFilter + SkDisplacementMapEffect is currently broken; logged separately as ...

7 years, 2 months ago (2013-10-08 19:56:51 UTC) #1

reed1

https://codereview.chromium.org/26531002/diff/4001/include/effects/SkDisplacementMapEffect.h File include/effects/SkDisplacementMapEffect.h (right): https://codereview.chromium.org/26531002/diff/4001/include/effects/SkDisplacementMapEffect.h#newcode29 include/effects/SkDisplacementMapEffect.h:29: const SkIRect* cropRect = NULL); Should this be SkRect, ...

7 years, 2 months ago (2013-10-09 12:48:40 UTC) #2

Stephen White

On 2013/10/09 12:48:40, reed1 wrote: > https://codereview.chromium.org/26531002/diff/4001/include/effects/SkDisplacementMapEffect.h > File include/effects/SkDisplacementMapEffect.h (right): > > https://codereview.chromium.org/26531002/diff/4001/include/effects/SkDisplacementMapEffect.h#newcode29 > ...

7 years, 2 months ago (2013-10-09 14:52:55 UTC) #3

bsalomon

On 2013/10/09 14:52:55, Stephen White wrote: > On 2013/10/09 12:48:40, reed1 wrote: > > > ...

7 years, 2 months ago (2013-10-09 14:55:33 UTC) #4

Stephen White

7 years, 2 months ago (2013-10-15 19:02:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r11782 (presubmit successful).

Expand Messages | Collapse Messages