Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2653083002: Cleanup ios/web_view. (Closed)

Created:
3 years, 11 months ago by michaeldo
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ios/web_view. Cleanup based on CL: https://codereview.chromium.org/2643773005 BUG=none

Patch Set 1 #

Patch Set 2 : Respond to more comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2461 lines, -0 lines) Patch
M ios/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web_view/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/web_view/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A ios/web_view/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/web_view/internal/BUILD.gn View 1 chunk +48 lines, -0 lines 0 comments Download
A ios/web_view/internal/DEPS View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv.mm View 1 chunk +73 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_browser_state.h View 1 chunk +59 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_browser_state.mm View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_network_delegate.h View 1 chunk +61 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_network_delegate.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_url_request_context_getter.h View 1 chunk +61 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_url_request_context_getter.mm View 1 chunk +163 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_client.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_client.mm View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_main_delegate.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_main_delegate.mm View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_main_parts.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_main_parts.mm View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_view_impl.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/web_view/internal/criwv_web_view_impl.mm View 1 1 chunk +242 lines, -0 lines 0 comments Download
A ios/web_view/internal/pref_names.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/web_view/internal/pref_names.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/web_view/internal/translate/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/web_view/internal/translate/criwv_translate_accept_languages_factory.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/web_view/internal/translate/criwv_translate_accept_languages_factory.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A ios/web_view/internal/translate/criwv_translate_client.h View 1 chunk +82 lines, -0 lines 0 comments Download
A ios/web_view/internal/translate/criwv_translate_client.mm View 1 chunk +146 lines, -0 lines 0 comments Download
A ios/web_view/internal/translate/criwv_translate_manager_impl.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/web_view/internal/translate/criwv_translate_manager_impl.mm View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/web_view/public/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/web_view/public/criwv.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/web_view/public/criwv_delegate.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/web_view/public/criwv_translate_delegate.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/web_view/public/criwv_translate_manager.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/web_view/public/criwv_web_view.h View 1 chunk +59 lines, -0 lines 0 comments Download
A ios/web_view/public/criwv_web_view_delegate.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/web_view/shell/BUILD.gn View 1 chunk +81 lines, -0 lines 0 comments Download
A ios/web_view/shell/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A ios/web_view/shell/Default-568h@2x.png View Binary file 0 comments Download
A ios/web_view/shell/Info.plist View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/web_view/shell/MainView.xib View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/web_view/shell/shell_app_delegate.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/web_view/shell/shell_app_delegate.mm View 1 1 chunk +57 lines, -0 lines 0 comments Download
A ios/web_view/shell/shell_delegate.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/web_view/shell/shell_delegate.mm View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/web_view/shell/shell_exe_main.mm View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/web_view/shell/shell_view_controller.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/web_view/shell/shell_view_controller.mm View 1 chunk +172 lines, -0 lines 0 comments Download
A ios/web_view/shell/textfield_background@2x.png View Binary file 0 comments Download
A ios/web_view/shell/toolbar_back@2x.png View Binary file 0 comments Download
A ios/web_view/shell/toolbar_forward@2x.png View Binary file 0 comments Download
A ios/web_view/shell/toolbar_stop@2x.png View Binary file 0 comments Download
A ios/web_view/shell/translate_controller.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/web_view/shell/translate_controller.mm View 1 chunk +69 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2643773005 Patch 20001

Messages

Total messages: 1 (1 generated)
michaeldo
3 years, 11 months ago (2017-01-24 22:35:14 UTC) #1 
Description was changed from

==========
Cleanup ios/web_view.

Cleanup based on CL: https://codereview.chromium.org/2643773005

BUG=none
==========

to

==========
Cleanup ios/web_view.

Cleanup based on CL: https://codereview.chromium.org/2643773005

BUG=none
==========

Powered by Google App Engine
This is Rietveld 408576698