chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js - Issue 2653023003: MD Settings: Update some dialogs to accept Enter key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

Issue 2653023003: MD Settings: Update some dialogs to accept Enter key. (Closed)

Patch Set: add 3 more similar ones Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

index bf275f9ac548d4c2b67bf3c21e3443c3407f8cfc..b941b1b98403c92dbe87e2c1630b7fc2cce2d25c 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

@@ -86,6 +86,10 @@ Polymer({

/** @private */

onActionButtonTap_: function() {

+ // This method may be called via keybinding, so we ignore invalid input.

+ if (this.$.actionButton.disabled)

+ return;

this.browserProxy_.searchEngineEditCompleted(

this.searchEngine_, this.keyword_, this.queryUrl_);

this.$.dialog.close();