Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> | 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> |
| 2 <link rel="import" href="chrome://resources/html/polymer.html"> | 2 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11 y-keys.html"> | |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> |
| 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> | 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> |
| 5 <link rel="import" href="/i18n_setup.html"> | 6 <link rel="import" href="/i18n_setup.html"> |
| 6 <link rel="import" href="/on_startup_page/startup_urls_page_browser_proxy.html"> | 7 <link rel="import" href="/on_startup_page/startup_urls_page_browser_proxy.html"> |
| 7 | 8 |
| 8 <dom-module id="settings-startup-url-dialog"> | 9 <dom-module id="settings-startup-url-dialog"> |
| 9 <template> | 10 <template> |
| 10 <style include="settings-shared"></style> | 11 <style include="settings-shared"></style> |
| 11 <dialog is="cr-dialog" id="dialog"> | 12 <dialog is="cr-dialog" id="dialog"> |
| 12 <div class="title">[[dialogTitle_]]</div> | 13 <div class="title">[[dialogTitle_]]</div> |
| 13 <div class="body"> | 14 <div class="body"> |
| 14 <paper-input always-float-label id="url" | 15 <paper-input always-float-label id="url" |
| 15 label="$i18n{onStartupSiteUrl}" | 16 label="$i18n{onStartupSiteUrl}" |
| 16 value="{{url_}}" on-input="validate_"> | 17 value="{{url_}}" on-input="validate_"> |
| 18 <iron-a11y-keys keys="enter" on-keys-pressed="onActionButtonTap_"> | |
|
dpapad
2017/01/25 00:47:29
What is the benefit of using <iron-a11y-keys> inst
tommycli
2017/01/25 01:01:47
No very strong reason, just:
1. Precedent... we
Dan Beam
2017/01/25 01:04:52
fwiw: i had this same question (why do you need an
| |
| 19 </iron-a11y-keys> | |
| 17 </paper-input> | 20 </paper-input> |
| 18 </div> | 21 </div> |
| 19 <div class="button-container"> | 22 <div class="button-container"> |
| 20 <div class="action-buttons"> | 23 <div class="action-buttons"> |
| 21 <paper-button class="cancel-button" on-tap="onCancelTap_" | 24 <paper-button class="cancel-button" on-tap="onCancelTap_" |
| 22 id="cancel">$i18n{cancel}</paper-button> | 25 id="cancel">$i18n{cancel}</paper-button> |
| 23 <paper-button id="actionButton" class="action-button" | 26 <paper-button id="actionButton" class="action-button" |
| 24 on-tap="onActionButtonTap_">[[actionButtonText_]]</paper-button> | 27 on-tap="onActionButtonTap_">[[actionButtonText_]]</paper-button> |
| 25 </div> | 28 </div> |
| 26 </div> | 29 </div> |
| 27 </dialog> | 30 </dialog> |
| 28 </template> | 31 </template> |
| 29 <script src="startup_url_dialog.js"></script> | 32 <script src="startup_url_dialog.js"></script> |
| 30 </dom-module> | 33 </dom-module> |
| OLD | NEW |