[scheduler] Plumb websocket information to scheduler

third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "core/frame/LocalFrame.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "core/loader/MixedContentChecker.h"
 #include "modules/websockets/InspectorWebSocketEvents.h"
 #include "modules/websockets/WebSocketChannelClient.h"
 #include "modules/websockets/WebSocketFrame.h"
 #include "modules/websockets/WebSocketHandleImpl.h"
+#include "platform/WebFrameScheduler.h"
 #include "platform/network/NetworkLog.h"
 #include "platform/network/WebSocketHandshakeRequest.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/InterfaceProvider.h"
 #include "public/platform/Platform.h"
 #include "wtf/PtrUtil.h"
 #include <memory>
 
 namespace blink {
 
@@ skipping 77 matching lines @@
       m_client(client),
       m_identifier(createUniqueIdentifier()),
       m_document(document),
       m_sendingQuota(0),
       m_receivedDataSizeForFlowControl(
           receivedDataSizeForFlowControlHighWaterMark * 2),  // initial quota
       m_sentSizeOfTopMessage(0),
       m_locationAtConstruction(std::move(location)) {}
 
 DocumentWebSocketChannel::~DocumentWebSocketChannel() {
   DCHECK(!m_blobLoader);

[alex clarke (OOO till 29th), 2017/01/24 18:15:33]

How well do we understand the lifetime of this object?  It's
GarbageCollectedFinalized so this destructor does get called. Is it possible for
DocumentWebSocketChannel::didConnect to get called but not one of 
DocumentWebSocketChannel::didFail /  DocumentWebSocketChannel::didClose?

[altimin, 2017/01/24 18:39:04]

Done.

 }
 
 bool DocumentWebSocketChannel::connect(const KURL& url,
                                        const String& protocol) {
   NETWORK_DVLOG(1) << this << " connect()";
   if (!m_handle)
     return false;
 
   if (document()->frame()) {
     if (MixedContentChecker::shouldBlockWebSocket(document()->frame(), url))
@@ skipping 295 matching lines @@
   return m_document;
 }
 
 void DocumentWebSocketChannel::didConnect(WebSocketHandle* handle,
                                           const String& selectedProtocol,
                                           const String& extensions) {
   NETWORK_DVLOG(1) << this << " didConnect(" << handle << ", "
                    << String(selectedProtocol) << ", " << String(extensions)
                    << ")";
 
+  if (document()->frame()) {
+    document()->frame()->frameScheduler()->didOpenWebSocket();
+  }

[alex clarke (OOO till 29th), 2017/01/24 18:15:33]

nit: although I prefer the google3 style braces I think chromium style is to not
have there in this case.

[altimin, 2017/01/24 18:39:04]

Acknowledged.

+
   DCHECK(m_handle);
   DCHECK_EQ(handle, m_handle.get());
   DCHECK(m_client);
 
   m_client->didConnect(selectedProtocol, extensions);
 }
 
 void DocumentWebSocketChannel::didStartOpeningHandshake(
     WebSocketHandle* handle,
     PassRefPtr<WebSocketHandshakeRequest> request) {
@@ skipping 24 matching lines @@
   InspectorInstrumentation::didReceiveWebSocketHandshakeResponse(
       document(), m_identifier, m_handshakeRequest.get(), response);
   m_handshakeRequest.clear();
 }
 
 void DocumentWebSocketChannel::didFail(WebSocketHandle* handle,
                                        const String& message) {
   NETWORK_DVLOG(1) << this << " didFail(" << handle << ", " << String(message)
                    << ")";
 
+  if (document()->frame()) {
+    document()->frame()->frameScheduler()->didCloseWebSocket();
+  }

[alex clarke (OOO till 29th), 2017/01/24 18:15:33]

Ditto.

[altimin, 2017/01/24 18:39:04]

Acknowledged.

+
   DCHECK(m_handle);
   DCHECK_EQ(handle, m_handle.get());
 
   // This function is called when the browser is required to fail the
   // WebSocketConnection. Hence we fail this channel by calling
   // |this->failAsError| function.
   failAsError(message);
   // |this| may be deleted.
 }
 
@@ skipping 62 matching lines @@
   }
 }
 
 void DocumentWebSocketChannel::didClose(WebSocketHandle* handle,
                                         bool wasClean,
                                         unsigned short code,
                                         const String& reason) {
   NETWORK_DVLOG(1) << this << " didClose(" << handle << ", " << wasClean << ", "
                    << code << ", " << String(reason) << ")";
 
+  if (document()->frame()) {
+    document()->frame()->frameScheduler()->didCloseWebSocket();
+  }
+
   DCHECK(m_handle);
   DCHECK_EQ(handle, m_handle.get());
 
   m_handle.reset();
 
   if (m_identifier) {
     TRACE_EVENT_INSTANT1(
         "devtools.timeline", "WebSocketDestroy", TRACE_EVENT_SCOPE_THREAD,
         "data", InspectorWebSocketEvent::data(document(), m_identifier));
     InspectorInstrumentation::didCloseWebSocket(document(), m_identifier);
@@ skipping 59 matching lines @@
   WebSocketChannel::trace(visitor);
 }
 
 std::ostream& operator<<(std::ostream& ostream,
                          const DocumentWebSocketChannel* channel) {
   return ostream << "DocumentWebSocketChannel "
                  << static_cast<const void*>(channel);
 }
 
 }  // namespace blink