Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 265293005: [New Multicolumn] Update sets' flow thread portion rectangles properly. (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)
Modified:
6 years, 7 months ago
CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New Multicolumn] Update sets' flow thread portion rectangles properly. logicalHeightOfAllFlowThreadContent() was wrong. This still doesn't matter much, but it will once we have support for multiple sets (column-span:all). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173769

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase master #

Patch Set 3 : Remove unnecessary call to validateRegions(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M Source/core/rendering/RenderFlowThread.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-05 15:22:21 UTC) #1
Julien - ping for review
https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/RenderMultiColumnSet.cpp File Source/core/rendering/RenderMultiColumnSet.cpp (right): https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/RenderMultiColumnSet.cpp#newcode295 Source/core/rendering/RenderMultiColumnSet.cpp:295: multiColumnFlowThread()->validateRegions(); RenderFlowThread::layout calls this function already so why would ...
6 years, 7 months ago (2014-05-06 23:45:59 UTC) #2
mstensho (USE GERRIT)
On 2014/05/06 23:45:59, Julien Chaffraix - PST wrote: > https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/RenderMultiColumnSet.cpp > File Source/core/rendering/RenderMultiColumnSet.cpp (right): > ...
6 years, 7 months ago (2014-05-07 05:13:53 UTC) #3
mstensho (USE GERRIT)
https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/RenderMultiColumnSet.cpp File Source/core/rendering/RenderMultiColumnSet.cpp (right): https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/RenderMultiColumnSet.cpp#newcode295 Source/core/rendering/RenderMultiColumnSet.cpp:295: multiColumnFlowThread()->validateRegions(); On 2014/05/06 23:46:00, Julien Chaffraix - PST wrote: ...
6 years, 7 months ago (2014-05-07 07:35:10 UTC) #4
Julien - ping for review
lgtm
6 years, 7 months ago (2014-05-09 16:31:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/265293005/40001
6 years, 7 months ago (2014-05-09 16:32:11 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 17:48:41 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 19:06:40 UTC) #8
Message was sent while issue was closed.
Change committed as 173769

Powered by Google App Engine
This is Rietveld 408576698