[New Multicolumn] Update sets' flow thread portion rectangles properly.

[New Multicolumn] Update sets' flow thread portion rectangles properly.

logicalHeightOfAllFlowThreadContent() was wrong. This still doesn't matter
much, but it will once we have support for multiple sets (column-span:all).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173769

[Julien - ping for review, 2014-05-06 23:45:59]

https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderMultiColumnSet.cpp (right):

https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderMultiColumnSet.cpp:295:
multiColumnFlowThread()->validateRegions();
RenderFlowThread::layout calls this function already so why would we need to
call it twice?

[mstensho (USE GERRIT), 2014-05-07 05:13:53]

On 2014/05/06 23:45:59, Julien Chaffraix - PST wrote:
>
https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/Render...
> File Source/core/rendering/RenderMultiColumnSet.cpp (right):
> 
>
https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/Render...
> Source/core/rendering/RenderMultiColumnSet.cpp:295:
> multiColumnFlowThread()->validateRegions();
> RenderFlowThread::layout calls this function already so why would we need to
> call it twice?

Multicol calculates the flow thread portion rectangle during layout. The call in
RenderFlowThread::layout() happens before layout. This is for the now mostly
gone regions code, where the region sizes were known before layout. I'll just
remove it.

[mstensho (USE GERRIT), 2014-05-07 07:35:10]

https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderMultiColumnSet.cpp (right):

https://codereview.chromium.org/265293005/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderMultiColumnSet.cpp:295:
multiColumnFlowThread()->validateRegions();
On 2014/05/06 23:46:00, Julien Chaffraix - PST wrote:
> RenderFlowThread::layout calls this function already so why would we need to
> call it twice?

Done.

[Julien - ping for review, 2014-05-09 16:31:10]

lgtm

[commit-bot: I haz the power, 2014-05-09 16:32:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mstensho@opera.com/265293005/40001

[commit-bot: I haz the power, 2014-05-09 17:48:41]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7098)

[commit-bot: I haz the power, 2014-05-09 19:06:40]

Change committed as 173769