Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp - Issue 265293004: Create fewer local v8::TryCatch objects in generated bindings code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp

Issue 265293004: Create fewer local v8::TryCatch objects in generated bindings code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp b/Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp

index d67730647f185d6c5ccf06fca18c9fc442023923..c9bcd4fdb0fbe359bcad213c86b2d1c4c2afc692 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp

@@ -50,7 +50,10 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

throwMinimumArityTypeErrorForConstructor("TestInterfaceConstructor3", 1, info.Length(), info.GetIsolate());

return;

}

- TOSTRING_VOID(V8StringResource<>, stringArg, info[0]);

+ V8StringResource<> stringArg;

+ {

+ TOSTRING_VOID_INTERNAL(stringArg, info[0]);

+ }

RefPtr<TestInterfaceConstructor3> impl = TestInterfaceConstructor3::create(stringArg);

v8::Handle<v8::Object> wrapper = info.Holder();