Source/bindings/scripts/v8_interface.py - Issue 265293004: Create fewer local v8::TryCatch objects in generated bindings code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 265293004: Create fewer local v8::TryCatch objects in generated bindings code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 01cc1ac3a66aaaf65c35356bf13f5e2f13c9076e..80049e1be1461fe5fc32d11eb13d9fac2311c69a 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -750,10 +750,14 @@ def sort_and_groupby(l, key=None):

# [Constructor]

def generate_constructor(interface, constructor):

+ arguments_need_try_catch = any(v8_methods.argument_needs_try_catch(argument)

+ for argument in constructor.arguments)

return {

'argument_list': constructor_argument_list(interface, constructor),

- 'arguments': [v8_methods.generate_argument(interface, constructor, argument, index)

+ 'arguments': [v8_methods.generate_argument(interface, constructor, argument, index, arguments_need_try_catch)

for index, argument in enumerate(constructor.arguments)],

+ 'arguments_need_try_catch': arguments_need_try_catch,

'cpp_type': cpp_template_type(

cpp_ptr_type('RefPtr', 'RawPtr', gc_type(interface)),

cpp_name(interface)),

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »