Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: Source/bindings/v8/V8StringResource.h

Issue 265293004: Create fewer local v8::TryCatch objects in generated bindings code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: avoid some unused v8::TryCatch objects Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8StringResource.h
diff --git a/Source/bindings/v8/V8StringResource.h b/Source/bindings/v8/V8StringResource.h
index e11002e5b0492b719f3bb4e560c5610ef63c0dce..c07536a42d4cf3f4eff1f863f365049c635e6d60 100644
--- a/Source/bindings/v8/V8StringResource.h
+++ b/Source/bindings/v8/V8StringResource.h
@@ -169,13 +169,22 @@ enum V8StringResourceMode {
template <V8StringResourceMode Mode = DefaultMode>
class V8StringResource {
public:
+ V8StringResource()
+ : m_mode(Externalize)
+ {
+ }
+
V8StringResource(v8::Handle<v8::Value> object)
: m_v8Object(object)
, m_mode(Externalize)
- , m_string()
{
}
+ void operator= (v8::Handle<v8::Value> object)
haraken 2014/05/08 03:45:06 Nit: Unnecessary space after '='.
Jens Widell 2014/05/08 16:38:05 Fixed.
+ {
+ m_v8Object = object;
+ }
+
bool prepare();
operator String() const { return toString<String>(); }
operator AtomicString() const { return toString<AtomicString>(); }
« Source/bindings/v8/V8BindingMacros.h ('K') | « Source/bindings/v8/V8BindingMacros.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698