Source/bindings/tests/results/V8TestSpecialOperations.cpp - Issue 265293004: Create fewer local v8::TryCatch objects in generated bindings code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperations.cpp

Issue 265293004: Create fewer local v8::TryCatch objects in generated bindings code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/tests/results/V8TestTypedefs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestSpecialOperations.cpp

diff --git a/Source/bindings/tests/results/V8TestSpecialOperations.cpp b/Source/bindings/tests/results/V8TestSpecialOperations.cpp

index 131a5a51884e232ab75f8612fb331bfa9696c4a0..c9e70b93ad88368bac141d8c7f6a36598b25db57 100644

--- a/Source/bindings/tests/results/V8TestSpecialOperations.cpp

+++ b/Source/bindings/tests/results/V8TestSpecialOperations.cpp

@@ -51,7 +51,11 @@ static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

return;

}

TestSpecialOperations* impl = V8TestSpecialOperations::toNative(info.Holder());

- TOSTRING_VOID(V8StringResource<>, name, info[0]);

+ V8StringResource<> name;

+ {

+ v8::TryCatch block;

+ TOSTRING_VOID_NO_DECL(name, info[0]);

+ }

bool result0Enabled = false;

RefPtr<Node> result0;

bool result1Enabled = false;

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/tests/results/V8TestTypedefs.cpp » ('j') | no next file with comments »