Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: third_party/WebKit/Source/platform/heap/TraceTraits.h

Issue 2652923002: Devirtualize Visitor and remove inline visitor specialization. (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/TraceTraits.h
diff --git a/third_party/WebKit/Source/platform/heap/TraceTraits.h b/third_party/WebKit/Source/platform/heap/TraceTraits.h
index 7e967449e3cd3c2365fe5137e533c236ab7c7329..fb5b1a0c01570df61e788b209b316c57da4f45fa 100644
--- a/third_party/WebKit/Source/platform/heap/TraceTraits.h
+++ b/third_party/WebKit/Source/platform/heap/TraceTraits.h
@@ -7,7 +7,6 @@
#include "platform/heap/GCInfo.h"
#include "platform/heap/Heap.h"
-#include "platform/heap/InlinedGlobalMarkingVisitor.h"
#include "platform/heap/StackFrameDepth.h"
#include "platform/heap/Visitor.h"
#include "platform/heap/WrapperVisitor.h"
@@ -202,7 +201,6 @@ class TraceTrait {
public:
static void trace(Visitor*, void* self);
- static void trace(InlinedGlobalMarkingVisitor, void* self);
static void markWrapperNoTracing(const WrapperVisitor*, const void*);
static void traceMarkedWrapper(const WrapperVisitor*, const void*);
@@ -233,18 +231,6 @@ class TraceTrait<const T> : public TraceTrait<T> {};
template <typename T>
void TraceTrait<T>::trace(Visitor* visitor, void* self) {
static_assert(WTF::IsTraceable<T>::value, "T should not be traced");
- if (visitor->isGlobalMarking()) {
- // Switch to inlined global marking dispatch.
- static_cast<T*>(self)->trace(InlinedGlobalMarkingVisitor(
- visitor->state(), visitor->getMarkingMode()));
- } else {
- static_cast<T*>(self)->trace(visitor);
- }
-}
-
-template <typename T>
-void TraceTrait<T>::trace(InlinedGlobalMarkingVisitor visitor, void* self) {
- static_assert(WTF::IsTraceable<T>::value, "T should not be traced");
static_cast<T*>(self)->trace(visitor);
}
« no previous file with comments | « third_party/WebKit/Source/platform/heap/RunAllTests.cpp ('k') | third_party/WebKit/Source/platform/heap/Visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698