Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/platform/heap/MarkingVisitor.h

Issue 2652923002: Devirtualize Visitor and remove inline visitor specialization. (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/MarkingVisitor.h
diff --git a/third_party/WebKit/Source/platform/heap/MarkingVisitor.h b/third_party/WebKit/Source/platform/heap/MarkingVisitor.h
deleted file mode 100644
index 9a07e69b891872cf05145db3e94d3b493e08a1e5..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/platform/heap/MarkingVisitor.h
+++ /dev/null
@@ -1,62 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef MarkingVisitor_h
-#define MarkingVisitor_h
-
-#include "platform/heap/MarkingVisitorImpl.h"
-
-namespace blink {
-
-class MarkingVisitor final : public Visitor,
- public MarkingVisitorImpl<MarkingVisitor> {
- public:
- using Impl = MarkingVisitorImpl<MarkingVisitor>;
-
- MarkingVisitor(ThreadState* state, VisitorMarkingMode mode)
- : Visitor(state, mode) {}
-
- void markHeader(HeapObjectHeader* header, TraceCallback callback) override {
- Impl::markHeader(header, header->payload(), callback);
- }
-
- void mark(const void* objectPointer, TraceCallback callback) override {
- Impl::mark(objectPointer, callback);
- }
-
- void registerDelayedMarkNoTracing(const void* object) override {
- Impl::registerDelayedMarkNoTracing(object);
- }
-
- void registerWeakMembers(const void* closure,
- const void* objectPointer,
- WeakCallback callback) override {
- Impl::registerWeakMembers(closure, objectPointer, callback);
- }
-
- virtual void registerWeakTable(const void* closure,
- EphemeronCallback iterationCallback,
- EphemeronCallback iterationDoneCallback) {
- Impl::registerWeakTable(closure, iterationCallback, iterationDoneCallback);
- }
-
-#if DCHECK_IS_ON()
- virtual bool weakTableRegistered(const void* closure) {
- return Impl::weakTableRegistered(closure);
- }
-#endif
-
- bool ensureMarked(const void* objectPointer) override {
- return Impl::ensureMarked(objectPointer);
- }
-
- void registerWeakCellWithCallback(void** cell,
- WeakCallback callback) override {
- Impl::registerWeakCellWithCallback(cell, callback);
- }
-};
-
-} // namespace blink
-
-#endif

Powered by Google App Engine
This is Rietveld 408576698