Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: src/effects/gradients/SkGradientShader.cpp

Issue 26529002: Fix uninitialized memory access (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/gradients/SkGradientShader.cpp
===================================================================
--- src/effects/gradients/SkGradientShader.cpp (revision 11645)
+++ src/effects/gradients/SkGradientShader.cpp (working copy)
@@ -1097,13 +1097,16 @@
*this->getColors(2) != *s.getColors(2)) {
return false;
}
+ } else {
+ if (fYCoord != s.getYCoord()) {
+ return false;
+ }
}
return fTextureAccess.getTexture() == s.fTextureAccess.getTexture() &&
fTextureAccess.getParams().getTileModeX() ==
s.fTextureAccess.getParams().getTileModeX() &&
this->useAtlas() == s.useAtlas() &&
- fYCoord == s.getYCoord() &&
fCoordTransform.getMatrix().cheapEqualTo(s.fCoordTransform.getMatrix());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698