Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: components/image_fetcher/image_data_fetcher.h

Issue 2652893005: Create the IOSImageDataFetcher (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/image_fetcher/image_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/image_fetcher/image_data_fetcher.h
diff --git a/components/image_fetcher/image_data_fetcher.h b/components/image_fetcher/image_data_fetcher.h
index 92c5a5cf0dc233d7c004adc58387f336115361bf..e578ba0aa22136046784a1e3d7cc66b97374e4cf 100644
--- a/components/image_fetcher/image_data_fetcher.h
+++ b/components/image_fetcher/image_data_fetcher.h
@@ -26,7 +26,8 @@ namespace image_fetcher {
class ImageDataFetcher : public net::URLFetcherDelegate {
public:
using ImageDataFetcherCallback =
- base::Callback<void(const std::string& image_data)>;
+ base::Callback<void(const std::string& image_data,
+ const net::URLFetcher* source)>;
gambard 2017/01/30 13:37:53 As the URLFetcher should probably not be exposed,
Marc Treib 2017/01/31 09:13:01 I still don't quite see why you need the response
gambard 2017/01/31 09:24:20 I agree that I can detect the type from the first
Marc Treib 2017/01/31 09:54:39 I'd prefer that; not only to keep the callback sim
using DataUseServiceName = data_use_measurement::DataUseUserData::ServiceName;
« no previous file with comments | « no previous file | components/image_fetcher/image_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698