Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: components/image_fetcher/image_data_fetcher.h

Issue 2652893005: Create the IOSImageDataFetcher (Closed)
Patch Set: Remove virtual Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/image_fetcher/image_data_fetcher.h
diff --git a/components/image_fetcher/image_data_fetcher.h b/components/image_fetcher/image_data_fetcher.h
index 92c5a5cf0dc233d7c004adc58387f336115361bf..e578ba0aa22136046784a1e3d7cc66b97374e4cf 100644
--- a/components/image_fetcher/image_data_fetcher.h
+++ b/components/image_fetcher/image_data_fetcher.h
@@ -26,7 +26,8 @@ namespace image_fetcher {
class ImageDataFetcher : public net::URLFetcherDelegate {
public:
using ImageDataFetcherCallback =
- base::Callback<void(const std::string& image_data)>;
+ base::Callback<void(const std::string& image_data,
+ const net::URLFetcher* source)>;
Marc Treib 2017/01/25 10:37:55 You'll have to update the tests for the new param.
markusheintz_ 2017/01/25 12:03:45 It would be great to learn what motivates this cha
gambard 2017/01/25 12:09:45 The IOSImageDataFetcher class is using the URLFetc
using DataUseServiceName = data_use_measurement::DataUseUserData::ServiceName;
« no previous file with comments | « no previous file | components/image_fetcher/image_data_fetcher.cc » ('j') | components/image_fetcher/ios/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698