Fuchsia: Implement memory region protections

Fuchsia: Implement memory region protections

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/672aab3cd3255fc4a669fa013bd703e12c3d1280

[zra, 2017-01-24 17:55:51]

zra@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[rmacnak, 2017-01-25 01:46:19]

lgtm

https://codereview.chromium.org/2652873002/diff/80001/runtime/vm/virtual_memo...
File runtime/vm/virtual_memory_fuchsia.cc (right):

https://codereview.chromium.org/2652873002/diff/80001/runtime/vm/virtual_memo...
runtime/vm/virtual_memory_fuchsia.cc:252: prot = MX_VM_FLAG_PERM_READ;
I would expect "0", but the wording of the syscall doc suggests at least one
permission is required. Magenta bug?

[zra, 2017-01-25 05:44:03]

https://codereview.chromium.org/2652873002/diff/80001/runtime/vm/virtual_memo...
File runtime/vm/virtual_memory_fuchsia.cc (right):

https://codereview.chromium.org/2652873002/diff/80001/runtime/vm/virtual_memo...
runtime/vm/virtual_memory_fuchsia.cc:252: prot = MX_VM_FLAG_PERM_READ;
On 2017/01/25 01:46:19, rmacnak wrote:
> I would expect "0", but the wording of the syscall doc suggests at least one
> permission is required. Magenta bug?

Not clear if it is a bug, or simply not yet implemented, but I've added a
comment with the issue number.

[zra, 2017-01-25 05:44:37]

Description was changed from

==========
Fuchsia: Implement memory region protections
==========

to

==========
Fuchsia: Implement memory region protections

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/672aab3cd3255fc4a669fa013bd703e12c3d1280
==========

[zra, 2017-01-25 05:44:38]

Committed patchset #7 (id:120001) manually as
672aab3cd3255fc4a669fa013bd703e12c3d1280 (presubmit successful).