Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: tools/perf/benchmarks/smoothness.py

Issue 2652833005: [PerfBenchmarks] Disable smoothness.scrolling_tough_ad_cases on Android and Linux (Closed)
Patch Set: Disable Linux as well Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import multiprocessing 4 import multiprocessing
5 5
6 from core import perf_benchmark 6 from core import perf_benchmark
7 7
8 from benchmarks import silk_flags 8 from benchmarks import silk_flags
9 from measurements import smoothness 9 from measurements import smoothness
10 import page_sets 10 import page_sets
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 return cls.IsSvelte(possible_browser) # http://crbug.com/555089 473 return cls.IsSvelte(possible_browser) # http://crbug.com/555089
474 474
475 @classmethod 475 @classmethod
476 def ValueCanBeAddedPredicate(cls, value, is_first_result): 476 def ValueCanBeAddedPredicate(cls, value, is_first_result):
477 del is_first_result # unused 477 del is_first_result # unused
478 # These pages don't scroll so it's not necessary to measure input latency. 478 # These pages don't scroll so it's not necessary to measure input latency.
479 return value.name != 'first_gesture_scroll_update_latency' 479 return value.name != 'first_gesture_scroll_update_latency'
480 480
481 481
482 # http://crbug.com/522619 (mac/win) 482 # http://crbug.com/522619 (mac/win)
483 @benchmark.Disabled('win', 'mac') 483 # http://crbug.com/683247 (android/linux)
484 @benchmark.Disabled('win', 'mac', 'android', 'linux')
484 class SmoothnessScrollingToughAdCases(_Smoothness): 485 class SmoothnessScrollingToughAdCases(_Smoothness):
485 """Measures rendering statistics while scrolling advertisements.""" 486 """Measures rendering statistics while scrolling advertisements."""
486 page_set = page_sets.ScrollingToughAdCasesPageSet 487 page_set = page_sets.ScrollingToughAdCasesPageSet
487 488
488 @classmethod 489 @classmethod
489 def ShouldDisable(cls, possible_browser): # http://crbug.com/597656 490 def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
490 return (possible_browser.browser_type == 'reference' and 491 return (possible_browser.browser_type == 'reference' and
491 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X') 492 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
492 493
493 @classmethod 494 @classmethod
494 def Name(cls): 495 def Name(cls):
495 return 'smoothness.scrolling_tough_ad_cases' 496 return 'smoothness.scrolling_tough_ad_cases'
496 497
497 498
498 class SmoothnessToughWebGLAdCases(_Smoothness): 499 class SmoothnessToughWebGLAdCases(_Smoothness):
499 """Measures rendering statistics while scrolling advertisements.""" 500 """Measures rendering statistics while scrolling advertisements."""
500 page_set = page_sets.SyntheticToughWebglAdCasesPageSet 501 page_set = page_sets.SyntheticToughWebglAdCasesPageSet
501 502
502 @classmethod 503 @classmethod
503 def Name(cls): 504 def Name(cls):
504 return 'smoothness.tough_webgl_ad_cases' 505 return 'smoothness.tough_webgl_ad_cases'
505 506
506 @classmethod 507 @classmethod
507 def ShouldDisable(cls, possible_browser): 508 def ShouldDisable(cls, possible_browser):
508 return cls.IsSvelte(possible_browser) # http://crbug.com/574485 509 return cls.IsSvelte(possible_browser) # http://crbug.com/574485
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698