Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 265283007: Remove broken %_Log functionality. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Some missing flag uses. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "code-stubs.h" 9 #include "code-stubs.h"
10 #include "codegen.h" 10 #include "codegen.h"
(...skipping 3047 matching lines...) Expand 10 before | Expand all | Expand 10 after
3058 __ Bind(&null); 3058 __ Bind(&null);
3059 __ LoadRoot(x0, Heap::kNullValueRootIndex); 3059 __ LoadRoot(x0, Heap::kNullValueRootIndex);
3060 3060
3061 // All done. 3061 // All done.
3062 __ Bind(&done); 3062 __ Bind(&done);
3063 3063
3064 context()->Plug(x0); 3064 context()->Plug(x0);
3065 } 3065 }
3066 3066
3067 3067
3068 void FullCodeGenerator::EmitLog(CallRuntime* expr) {
3069 // Conditionally generate a log call.
3070 // Args:
3071 // 0 (literal string): The type of logging (corresponds to the flags).
3072 // This is used to determine whether or not to generate the log call.
3073 // 1 (string): Format string. Access the string at argument index 2
3074 // with '%2s' (see Logger::LogRuntime for all the formats).
3075 // 2 (array): Arguments to the format string.
3076 ZoneList<Expression*>* args = expr->arguments();
3077 ASSERT_EQ(args->length(), 3);
3078 if (CodeGenerator::ShouldGenerateLog(isolate(), args->at(0))) {
3079 VisitForStackValue(args->at(1));
3080 VisitForStackValue(args->at(2));
3081 __ CallRuntime(Runtime::kHiddenLog, 2);
3082 }
3083
3084 // Finally, we're expected to leave a value on the top of the stack.
3085 __ LoadRoot(x0, Heap::kUndefinedValueRootIndex);
3086 context()->Plug(x0);
3087 }
3088
3089
3090 void FullCodeGenerator::EmitSubString(CallRuntime* expr) { 3068 void FullCodeGenerator::EmitSubString(CallRuntime* expr) {
3091 // Load the arguments on the stack and call the stub. 3069 // Load the arguments on the stack and call the stub.
3092 SubStringStub stub(isolate()); 3070 SubStringStub stub(isolate());
3093 ZoneList<Expression*>* args = expr->arguments(); 3071 ZoneList<Expression*>* args = expr->arguments();
3094 ASSERT(args->length() == 3); 3072 ASSERT(args->length() == 3);
3095 VisitForStackValue(args->at(0)); 3073 VisitForStackValue(args->at(0));
3096 VisitForStackValue(args->at(1)); 3074 VisitForStackValue(args->at(1));
3097 VisitForStackValue(args->at(2)); 3075 VisitForStackValue(args->at(2));
3098 __ CallStub(&stub); 3076 __ CallStub(&stub);
3099 context()->Plug(x0); 3077 context()->Plug(x0);
(...skipping 1831 matching lines...) Expand 10 before | Expand all | Expand 10 after
4931 return previous_; 4909 return previous_;
4932 } 4910 }
4933 4911
4934 4912
4935 #undef __ 4913 #undef __
4936 4914
4937 4915
4938 } } // namespace v8::internal 4916 } } // namespace v8::internal
4939 4917
4940 #endif // V8_TARGET_ARCH_ARM64 4918 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698