Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 265283007: Remove broken %_Log functionality. (Closed)

Created:
6 years, 7 months ago by Michael Starzinger
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Remove broken %_Log functionality. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21160

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Yang Guo. #

Patch Set 3 : Some missing flag uses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -275 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +1 line, -12 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/codegen.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +1 line, -12 lines 0 comments Download
M src/log.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/log.cc View 1 1 chunk +0 lines, -41 lines 0 comments Download
M src/log-utils.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/log-utils.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +1 line, -12 lines 0 comments Download
M src/regexp.js View 3 chunks +0 lines, -3 lines 0 comments Download
M src/runtime.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/string.js View 3 chunks +0 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
Turns out that having dead code in the code-base is a bad idea. The --log-regexp ...
6 years, 7 months ago (2014-05-06 08:26:26 UTC) #1
Yang
Good riddance. LGTM with comments. https://codereview.chromium.org/265283007/diff/1/src/runtime.h File src/runtime.h (right): https://codereview.chromium.org/265283007/diff/1/src/runtime.h#newcode547 src/runtime.h:547: F(Log, 2, 1) \ ...
6 years, 7 months ago (2014-05-06 08:31:32 UTC) #2
Michael Starzinger
Thanks for the review. Addressed comment. Landing. https://codereview.chromium.org/265283007/diff/1/src/runtime.h File src/runtime.h (right): https://codereview.chromium.org/265283007/diff/1/src/runtime.h#newcode547 src/runtime.h:547: F(Log, 2, ...
6 years, 7 months ago (2014-05-06 08:57:20 UTC) #3
Michael Starzinger
6 years, 7 months ago (2014-05-06 09:28:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698