Add accessibility function to PDFScriptingAPI

Add accessibility function to PDFScriptingAPI

This adds the ability to fetch accessibility data from the plugin. It also adds a test for this function.

BUG=303491
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269742

[Lei Zhang, 2014-05-08 06:42:52]

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf.js:283: case 'getAccessibilityJSONReply':
consider putting the cases in alphabetical order

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf_scripting_api.js (right):

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf_scripting_api.js:128: * @param {number} [page]
the index of the page to get accessibility data for.
Is this 0 indexed or 1 indexed?

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf_scripting_api.js:130: * @return {boolean} true
if the function is successful, false if there is an
Should we leave this as is, or queue up the requests and handle them?

Dominic may have an opinion on this.

https://codereview.chromium.org/265283005/diff/20001/chrome/test/data/pdf/bas...
File chrome/test/data/pdf/basic_plugin_test.js (right):

https://codereview.chromium.org/265283005/diff/20001/chrome/test/data/pdf/bas...
chrome/test/data/pdf/basic_plugin_test.js:37:
'"height":8.8680419921875,"left":77.13200378417969,' +
Are these values going to work cross-platform?

[dmazzoni, 2014-05-08 13:33:56]

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf_scripting_api.js (right):

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf_scripting_api.js:130: * @return {boolean} true
if the function is successful, false if there is an
On 2014/05/08 06:42:53, Lei Zhang wrote:
> Should we leave this as is, or queue up the requests and handle them?
> 
> Dominic may have an opinion on this.

This should be fine, we can wait for the first page to return before requesting
the second.

[raymes, 2014-05-09 06:19:45]

Thanks!

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf.js:283: case 'getAccessibilityJSONReply':
On 2014/05/08 06:42:53, Lei Zhang wrote:
> consider putting the cases in alphabetical order

Done.

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf_scripting_api.js (right):

https://codereview.chromium.org/265283005/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf_scripting_api.js:128: * @param {number} [page]
the index of the page to get accessibility data for.
On 2014/05/08 06:42:53, Lei Zhang wrote:
> Is this 0 indexed or 1 indexed?

0 indexed.

https://codereview.chromium.org/265283005/diff/20001/chrome/test/data/pdf/bas...
File chrome/test/data/pdf/basic_plugin_test.js (right):

https://codereview.chromium.org/265283005/diff/20001/chrome/test/data/pdf/bas...
chrome/test/data/pdf/basic_plugin_test.js:37:
'"height":8.8680419921875,"left":77.13200378417969,' +
Good point - I got rid of the checks for floating point data.

[Lei Zhang, 2014-05-09 22:54:28]

lgtm

[commit-bot: I haz the power, 2014-05-09 22:56:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/265283005/60001

[commit-bot: I haz the power, 2014-05-10 00:26:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-10 00:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 00:31:46]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[raymes, 2014-05-12 03:58:27]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-05-12 03:58:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/265283005/80001

[commit-bot: I haz the power, 2014-05-12 05:35:17]

Change committed as 269742