Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/ui/update_chrome_dialog_browsertest.cc

Issue 2652823003: Add "Relaunch Chrome" dialog to Mac Views. (Closed)
Patch Set: Disable on Linux and Windows Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/command_line.h"
6 #include "chrome/browser/ui/browser_window.h"
7 #include "chrome/browser/ui/test/test_browser_dialog.h"
8 #include "ui/base/ui_base_switches.h"
9
10 #if !defined(OS_MACOSX)
tapted 2017/01/24 04:36:42 nit: move down to line 34 ? (I usually see these l
Greg K 2017/01/24 05:57:16 Done.
11 // Initially disabled except on Mac due to http://crbug.com/683808.
12 #define MAYBE_InvokeDialog_default DISABLED_InvokeDialog_default
13 #else
14 #define MAYBE_InvokeDialog_default InvokeDialog_default
15 #endif
16
17 class UpdateRecommendedDialogTest : public DialogBrowserTest {
18 public:
19 UpdateRecommendedDialogTest() {}
20
21 // DialogBrowserTesT:
tapted 2017/01/24 04:36:42 nit: DialogBrowserTesT: -> DialogBrowserTest:
Greg K 2017/01/24 05:57:17 Done.
22 void ShowDialog(const std::string& name) override {
23 InProcessBrowserTest::browser()->window()->ShowUpdateChromeDialog();
24 }
25
26 // content::BrowserTestBase:
27 void SetUpCommandLine(base::CommandLine* command_line) override {
28 command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);
29 }
30
31 private:
32 DISALLOW_COPY_AND_ASSIGN(UpdateRecommendedDialogTest);
33 };
34
35 // Test that calls ShowDialog("default"). Interactive when run via
36 // browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
37 // --dialog=UpdateRecommendedDialogTest.InvokeDialog_default
38 IN_PROC_BROWSER_TEST_F(UpdateRecommendedDialogTest,
39 MAYBE_InvokeDialog_default) {
40 RunDialog();
41 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/browser_dialogs_views_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698