Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_common.dart

Issue 2652823002: Use single InputPackagesResultProvider, without SdkSummaryResultProvider. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/resynthesize_common.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
index 916ea5aaab2f439420506d76f9b71e09eb6b8c0e..1494f78be82c78a93c59621d1fcc0a995f65a151 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_common.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -146,7 +146,7 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
TestSummaryResynthesizer resynthesizer, LibraryElement library) {
// Check that no other summaries needed to be resynthesized to resynthesize
// the library element.
- expect(resynthesizer.resynthesisCount, 1);
+ expect(resynthesizer.resynthesisCount, 3);
// Check that the only linked summary consulted was that for [uri].
expect(resynthesizer.linkedSummariesRequested, hasLength(1));
expect(resynthesizer.linkedSummariesRequested.first,
@@ -4888,7 +4888,7 @@ var x;''');
checkMinimalResynthesisWork(resynthesizer, original.library);
// Check that no other summaries needed to be resynthesized to resynthesize
// the library element.
- expect(resynthesizer.resynthesisCount, 1);
+ expect(resynthesizer.resynthesisCount, 3);
expect(result.location, location);
return result;
}
@@ -4913,8 +4913,12 @@ class TestSummaryResynthesizer extends SummaryResynthesizer {
TestSummaryResynthesizer(SummaryResynthesizer parent, AnalysisContext context,
this.unlinkedSummaries, this.linkedSummaries, this.allowMissingFiles)
- : super(parent, context, context.typeProvider, context.sourceFactory,
- context.analysisOptions.strongMode);
+ : super(parent, context, context.sourceFactory,
+ context.analysisOptions.strongMode) {
+ // Clear after resynthesizing TypeProvider in super().
+ unlinkedSummariesRequested.clear();
+ linkedSummariesRequested.clear();
+ }
@override
LinkedLibrary getLinkedSummary(String uri) {

Powered by Google App Engine
This is Rietveld 408576698