Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 2652823002: Use single InputPackagesResultProvider, without SdkSummaryResultProvider. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index 52a64b7fc47df3d2b1a8b85632b4658ff2c80400..c5a1525d315b05616b63942d6a56431568a291c5 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -204,6 +204,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
*/
List<AnalysisListener> _listeners = new List<AnalysisListener>();
+ /**
+ * When we resynthesize SDK element model in the same context, we should
+ * not use a separate SDK cache partition.
Paul Berry 2017/01/23 22:36:45 I'm having trouble understanding which parts of th
scheglov 2017/01/23 22:44:49 Done.
+ */
+ bool useSdkCachePartition = true;
+
@override
ResultProvider resultProvider;
@@ -739,6 +745,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {
if (factory == null) {
return new AnalysisCache(<CachePartition>[_privatePartition]);
}
+ if (!useSdkCachePartition) {
+ return new AnalysisCache(<CachePartition>[_privatePartition]);
+ }
DartSdk sdk = factory.dartSdk;
if (sdk == null) {
return new AnalysisCache(<CachePartition>[_privatePartition]);

Powered by Google App Engine
This is Rietveld 408576698