Use single InputPackagesResultProvider, without SdkSummaryResultProvider.

Use single InputPackagesResultProvider, without SdkSummaryResultProvider.

Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com, vsm@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/c9e1b888a3c72617eb727e31239760c3c617eff2

[Brian Wilkerson, 2017-01-23 22:25:41]

lgtm

[Paul Berry, 2017-01-23 22:36:46]

lgtm

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:209: * not use a separate SDK cache
partition.
I'm having trouble understanding which parts of this comment explain what the
bool does and which parts give advice as to how to set it correctly.  Maybe
change it to something like this?

"Determines whether this context should attempt to make use of the global SDK
cache partition.  Note that if this context is responsible for resynthesizing
the SDK element model, this boolean should be set to `false`, so that
resynthesized elements belonging to this context won't leak into the global SDK
cache partition."

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:424: : super(null,
context, sourceFactory, strongMode);
It looks like there are no remaining code paths that pass a non-null parent to
the superclass constructor.  Can we get rid of this constructor parameter now
(and the associated logic inside the superclass)?

(Ok with me if you want to postpone this to a follow-up CL)

[scheglov, 2017-01-23 22:43:42]

Description was changed from

==========
Use single InputPackagesResultProvider, without SdkSummaryResultProvider.

Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Use single InputPackagesResultProvider, without SdkSummaryResultProvider.

Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com, vsm@google.com
BUG=
==========

[scheglov, 2017-01-23 22:43:54]

scheglov@google.com changed reviewers:
+ vsm@google.com

[scheglov, 2017-01-23 22:44:50]

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:209: * not use a separate SDK cache
partition.
On 2017/01/23 22:36:45, Paul Berry wrote:
> I'm having trouble understanding which parts of this comment explain what the
> bool does and which parts give advice as to how to set it correctly.  Maybe
> change it to something like this?
> 
> "Determines whether this context should attempt to make use of the global SDK
> cache partition.  Note that if this context is responsible for resynthesizing
> the SDK element model, this boolean should be set to `false`, so that
> resynthesized elements belonging to this context won't leak into the global
SDK
> cache partition."

Done.

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/2652823002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:424: : super(null,
context, sourceFactory, strongMode);
On 2017/01/23 22:36:45, Paul Berry wrote:
> It looks like there are no remaining code paths that pass a non-null parent to
> the superclass constructor.  Can we get rid of this constructor parameter now
> (and the associated logic inside the superclass)?
> 
> (Ok with me if you want to postpone this to a follow-up CL)

Yes, I want to clean this up in the following CL.

[scheglov, 2017-01-23 23:13:10]

PTAL

I had to make additional changes for DDC and analyzer_cli.

[Brian Wilkerson, 2017-01-23 23:28:20]

lgtm

[vsm, 2017-01-23 23:43:38]

lgtm

https://codereview.chromium.org/2652823002/diff/40001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2652823002/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/compiler.dart:89: summaryData.addBundle(null,
sdk.getLinkedBundle());
Does it make sense to pass the sdk to the SummaryDataStore constructor and just
set it there?

[scheglov, 2017-01-24 00:54:24]

Description was changed from

==========
Use single InputPackagesResultProvider, without SdkSummaryResultProvider.

Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com, vsm@google.com
BUG=
==========

to

==========
Use single InputPackagesResultProvider, without SdkSummaryResultProvider.

Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com, vsm@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/c9e1b888a3c72617eb727e31239760c3c617eff2
==========

[scheglov, 2017-01-24 00:54:25]

Committed patchset #3 (id:40001) manually as
c9e1b888a3c72617eb727e31239760c3c617eff2 (presubmit successful).