Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: components/sync/engine/browser_thread_model_worker_unittest.cc

Issue 2652673006: Don't call Timer::Stop() off-sequence in SyncBrowserThreadModelWorkerTest (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine/browser_thread_model_worker_unittest.cc
diff --git a/components/sync/engine/browser_thread_model_worker_unittest.cc b/components/sync/engine/browser_thread_model_worker_unittest.cc
index 4e3c01fa38a03bceaefd4034246d89d943f6eeb8..f05d2b8795c640082608ea29036cf96cdef0a58d 100644
--- a/components/sync/engine/browser_thread_model_worker_unittest.cc
+++ b/components/sync/engine/browser_thread_model_worker_unittest.cc
@@ -50,7 +50,6 @@ class SyncBrowserThreadModelWorkerTest : public testing::Test {
// This is the work that will be scheduled to be done on the DB thread.
SyncerError DoWork() {
EXPECT_TRUE(db_thread_.task_runner()->BelongsToCurrentThread());
- timer_.Stop(); // Stop the failure timer so the test succeeds.
stanisc 2017/01/25 00:55:16 Would it make sense to remove timer_ completely an
gab 2017/01/25 14:51:47 Yes it does but since there are many erroneous cas
main_message_loop_.task_runner()->PostTask(
FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());
did_do_work_ = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698