Issue 2652663005: Handle field initializers correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2652663005: Handle field initializers correctly. (Closed)

Created:
3 years, 11 months ago by ahe

Modified:
3 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/fasta

Project:
Fasta

Visibility:
Public.

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -12 lines)			Patch
M	pkg/dart_parser/lib/src/listener.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/dart_parser/lib/src/parser.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/fasta/lib/src/kernel/body_builder.dart	View	3 chunks	+23 lines, -12 lines	0 comments	Download
M	pkg/fasta/lib/src/source/diet_listener.dart	View	13 chunks	+60 lines, -0 lines	0 comments	Download
M	pkg/fasta/lib/src/source/outline_builder.dart	View	25 chunks	+55 lines, -0 lines	0 comments	Download
M	pkg/fasta/lib/src/source/stack_listener.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

ahe

I hadn't tested my changes to fasta, and the existing tests uncovered this issue.

3 years, 11 months ago (2017-01-24 10:28:08 UTC) #2

ahe

3 years, 11 months ago (2017-01-24 15:06:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bbdb06ce872cd95e257989a77aabec5f1681b269 (presubmit successful).