Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: ui/gfx/color_transform_unittest.cc

Issue 2652503002: Use SkICC in gfx::ICCProfile and gfx::ColorSpace (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/color_transform_unittest.cc
diff --git a/ui/gfx/color_transform_unittest.cc b/ui/gfx/color_transform_unittest.cc
index c99268783bc50098e47e990d0e381da989ad52bf..98df52b9ce5c0a90c5ca7bf2fa484649de41930b 100644
--- a/ui/gfx/color_transform_unittest.cc
+++ b/ui/gfx/color_transform_unittest.cc
@@ -117,6 +117,7 @@ TEST(SimpleColorSpace, GetColorSpace) {
ICCProfile srgb_icc = ICCProfileForTestingSRGB();
ColorSpace sRGB = srgb_icc.GetColorSpace();
ColorSpace sRGB2 = sRGB;
+ const float kEpsilon = 0.0012f;
// Prevent sRGB2 from using a cached ICC profile.
sRGB2.icc_profile_id_ = 0;
@@ -126,27 +127,27 @@ TEST(SimpleColorSpace, GetColorSpace) {
ColorTransform::TriStim tmp(1.0f, 1.0f, 1.0f);
t->transform(&tmp, 1);
- EXPECT_NEAR(tmp.x(), 1.0f, 0.001f);
- EXPECT_NEAR(tmp.y(), 1.0f, 0.001f);
- EXPECT_NEAR(tmp.z(), 1.0f, 0.001f);
+ EXPECT_NEAR(tmp.x(), 1.0f, kEpsilon);
+ EXPECT_NEAR(tmp.y(), 1.0f, kEpsilon);
+ EXPECT_NEAR(tmp.z(), 1.0f, kEpsilon);
tmp = ColorTransform::TriStim(1.0f, 0.0f, 0.0f);
t->transform(&tmp, 1);
- EXPECT_NEAR(tmp.x(), 1.0f, 0.001f);
- EXPECT_NEAR(tmp.y(), 0.0f, 0.001f);
- EXPECT_NEAR(tmp.z(), 0.0f, 0.001f);
+ EXPECT_NEAR(tmp.x(), 1.0f, kEpsilon);
+ EXPECT_NEAR(tmp.y(), 0.0f, kEpsilon);
+ EXPECT_NEAR(tmp.z(), 0.0f, kEpsilon);
tmp = ColorTransform::TriStim(0.0f, 1.0f, 0.0f);
t->transform(&tmp, 1);
- EXPECT_NEAR(tmp.x(), 0.0f, 0.001f);
- EXPECT_NEAR(tmp.y(), 1.0f, 0.001f);
- EXPECT_NEAR(tmp.z(), 0.0f, 0.001f);
+ EXPECT_NEAR(tmp.x(), 0.0f, kEpsilon);
+ EXPECT_NEAR(tmp.y(), 1.0f, kEpsilon);
+ EXPECT_NEAR(tmp.z(), 0.0f, kEpsilon);
tmp = ColorTransform::TriStim(0.0f, 0.0f, 1.0f);
t->transform(&tmp, 1);
- EXPECT_NEAR(tmp.x(), 0.0f, 0.001f);
- EXPECT_NEAR(tmp.y(), 0.0f, 0.001f);
- EXPECT_NEAR(tmp.z(), 1.0f, 0.001f);
+ EXPECT_NEAR(tmp.x(), 0.0f, kEpsilon);
+ EXPECT_NEAR(tmp.y(), 0.0f, kEpsilon);
+ EXPECT_NEAR(tmp.z(), 1.0f, kEpsilon);
}
TEST(SimpleColorSpace, UnknownToSRGB) {
« ui/gfx/color_transform.cc ('K') | « ui/gfx/color_transform.cc ('k') | ui/gfx/icc_profile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698