Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: pkg/analyzer/test/generated/parser_test.dart

Issue 2652443003: Fix GenericFunctionType parsing tests by making them fail in non-checked mode. (Closed)
Patch Set: Add TODO comments to improve tests after enabling the feature. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/parser_test.dart
diff --git a/pkg/analyzer/test/generated/parser_test.dart b/pkg/analyzer/test/generated/parser_test.dart
index 2085d19da252951d929d50dcf5b8464eea4a3e92..221755ab831d083c9e64d22756696652865137a3 100644
--- a/pkg/analyzer/test/generated/parser_test.dart
+++ b/pkg/analyzer/test/generated/parser_test.dart
@@ -13644,7 +13644,8 @@ void''');
@failingTest
void test_parseTypeAnnotation_function_returnType_function() {
createParser('A Function(B, C) Function(D) v');
- GenericFunctionType functionType = parser.parseTypeAnnotation(false);
+ // TODO(scheglov) improve the test to verify also the node properties
+ var functionType = parser.parseTypeAnnotation(false) as GenericFunctionType;
expectNotNullIfNoErrors(functionType);
listener.assertNoErrors();
}
@@ -13695,7 +13696,8 @@ void''');
@failingTest
void test_parseTypeAnnotation_function_returnType_simple() {
createParser('A Function(B, C) v');
- GenericFunctionType functionType = parser.parseTypeAnnotation(false);
+ // TODO(scheglov) improve the test to verify also the node properties
+ var functionType = parser.parseTypeAnnotation(false) as GenericFunctionType;
expectNotNullIfNoErrors(functionType);
listener.assertNoErrors();
}
@@ -13736,7 +13738,8 @@ void''');
@failingTest
void test_parseTypeAnnotation_function_returnType_withArguments() {
createParser('A<B> Function(C) v');
- GenericFunctionType functionType = parser.parseTypeAnnotation(false);
+ // TODO(scheglov) improve this test to verify also the node properties
+ var functionType = parser.parseTypeAnnotation(false) as GenericFunctionType;
expectNotNullIfNoErrors(functionType);
listener.assertNoErrors();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698