Fix GenericFunctionType parsing tests by making them fail in non-checked mode.

Fix GenericFunctionType parsing tests by making them fail in non-checked mode.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/8cf71084dc4f6710afc4bf2af47f659759942245

[Brian Wilkerson, 2017-01-21 17:03:25]

I don't understand this CL.

1. We always run tests in checked mode, so I don't understand why we care about
non-checked mode behavior.

2. Generic function type support is currently disabled, so these tests will fail
for completely different reasons anyway.

3. There are lots of other tests in that file (and other files) that use the
same pattern that you didn't update so they won't work in non-checked mode
either.

[scheglov, 2017-01-21 17:21:21]

On 2017/01/21 17:03:25, Brian Wilkerson wrote:
> I don't understand this CL.
> 
> 1. We always run tests in checked mode, so I don't understand why we care
about
> non-checked mode behavior.
> 
> 2. Generic function type support is currently disabled, so these tests will
fail
> for completely different reasons anyway.
> 
> 3. There are lots of other tests in that file (and other files) that use the
> same pattern that you didn't update so they won't work in non-checked mode
> either.

1. I run tests from the command line in non-checked mode for speed.

2. The updated tests don't test much, only the fact that something non-null was
returned.

3. The other tests ask also a GenericFunctionType property, so fail anyway.

[Brian Wilkerson, 2017-01-21 17:46:12]

> The updated tests don't test much, only the fact that something non-null was
returned.

Good point. Personally, I think a better way to "fix" the tests would be to
enhance them to test the state of the returned objects, which would not only
cause them to fail in unchecked mode but also to test the behavior more
completely.

If you choose not to do so, please add a TODO to the tests to that effect, at
which point lgtm.

[scheglov, 2017-01-21 22:32:42]

Description was changed from

==========
Fix GenericFunctionType parsing tests by making them fail in non-checked mode.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Fix GenericFunctionType parsing tests by making them fail in non-checked mode.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8cf71084dc4f6710afc4bf2af47f659759942245
==========

[scheglov, 2017-01-21 22:32:43]

Committed patchset #2 (id:20001) manually as
8cf71084dc4f6710afc4bf2af47f659759942245 (presubmit successful).